telemetry(amazonq): emit TransformEvent metric from download ZIP #5905
Conversation
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts
Outdated
Show resolved
Hide resolved
dhasani23
force-pushed
the
metrics
branch
2 times, most recently
from
d328ee5 to
b840289
Compare
| transformEvent: { | ||
| jobId: transformByQState.getJobId(), | ||
| timestamp: new Date(), | ||
| ideCategory: 'VSCODE', |
There was a problem hiding this comment.
Is there any constant value we can extract this VSCODE value from? Same for JAVA and SQL below
There was a problem hiding this comment.
+1, do we have enum e.g. IdeCategory or constants represent IDE or get it from IDE env ?
There was a problem hiding this comment.
I don't see this no. All other uses in toolkit seem to use VSCODE just like this
dhasani23
force-pushed
the
metrics
branch
2 times, most recently
from
f83e441 to
18b6adb
Compare
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
dhasani23
changed the title
| userContext: { | ||
| ideCategory: 'VSCODE', | ||
| operatingSystem: getOperatingSystem(), | ||
| product: 'CodeWhisperer', |
There was a problem hiding this comment.
should it be AmazonQ ?
There was a problem hiding this comment.
Yep that makes more sense
There was a problem hiding this comment.
On second thought, I shouldn't even be manually including this userContext here — it's already included in the request, so we should simply use that:
Problem
Need some more metrics emitted to capture lines of code submitted, lines of code changed, and characters of code changed.
Solution
Emit said metrics after parsing them from the download ZIP.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.