Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jscpd): change pattern to allow for nested script patterns. #5930

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Hweinstock
Copy link
Contributor

Problem

The current pattern will not catch the script files because they are nested beyond one directory deep.

Solution

change it to **/script/**.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock requested a review from a team as a code owner November 5, 2024 20:37
Copy link

github-actions bot commented Nov 5, 2024

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@justinmk3 justinmk3 merged commit 1486e3a into aws:master Nov 5, 2024
11 checks passed
@Hweinstock Hweinstock deleted the fixScriptIgnore branch November 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants