fix(amazonq): tutorial always showing on start #5949
Conversation
|
| @@ -122,6 +122,9 @@ export class InlineChatController { | |||
| } | |||
|
|
|||
| public async updateTaskAndLenses(task: InlineTask, taskState?: TaskState) { | |||
| if (!task) { | |||
There was a problem hiding this comment.
How is this possible? The parameter type is non-nullable / non-falsey.
There was a problem hiding this comment.
Unclear when this could happen. This is an attempt to fix an issue reported by a customer where I believe the logic in this function is running with a undefined task, I can not find any other codepath that would produce this error:
I can make the task optional to make this clearer at least.
There was a problem hiding this comment.
I can make the task optional to make this clearer at least.
That is the bare minimum, yes.
The cause of this bug is likely related to the fact that task = this.task may be undefined.
It's probably a good idea to track down the root cause, because this signals that there are other parts of the code that are forcing things (e.g. with !) that they shouldn't be forcing. Or there is unclear initialization ordering.
There was a problem hiding this comment.
Is this code still missing tests?
justinmk3
changed the title
The LineAnnotationController could get stuck showing the tutorial for new users due to changes in the inline chat logic, this PR resolve that bug and prevents the
aws.codewhisperer.tutorial.workInProgressfrom being set totruewhen using inline chat.Additional a more descriptive error log for the
computeDiffAndRenderOnEditorfunction call and check for not null inupdateTaskAndLensesLicense: I confirm that my contribution is made under the terms of the Apache 2.0 license.