test(ssh): Add explicit timeout on child process to avoid hanging. #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hweinstock
changed the title
|
/runIntegrationTests |
justinmk3
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Starting in #5936 some tests started expiring, since fixed in #5954. However, rather than expire, the
SshKeyPairtests hang because they are stuck in a child process. This leads to these tests failing to timeout, even when exceeding the test timeout threshold.Solution
Add explicit timeout on the child process we use to spawn ssh keys.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.