Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): wrongly formatted supplemental context for inline suggestion #5963

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 8, 2024

Problem

List of fixes:

  • def func (a) : -> def func(a):
  • class (A) : -> class(A):
  • for python, change // Function definitions to # Function definitions , // Class definitions to # Class definitions
  • for js/ts: function findMax (arr: number[]) : number | undefined{. -> function findMax(arr: number[]): number | undefined {.
  • for all language: // File path: a.ts -> //File path a.ts
  • for js/ts: String privateString ; -> String privateString;

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Nov 8, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua changed the title bump amazonq helper version to 0.1.27 fix(amazonq): wrongly formatted supplemental context for inline suggestion Nov 8, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 8, 2024 18:14
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners November 8, 2024 18:14
@justinmk3 justinmk3 merged commit d5a7e8e into aws:master Nov 8, 2024
10 of 17 checks passed
@Will-ShaoHua Will-ShaoHua deleted the lsp-bump branch November 8, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants