config(amazonq): update Q API model #5965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will-ShaoHua
commented
Nov 8, 2024
Comment on lines
+5
to
+12
| "auth": ["smithy.api#httpBearerAuth"], | ||
| "endpointPrefix": "amazoncodewhispererservice", | ||
| "jsonVersion": "1.0", | ||
| "protocol": "json", | ||
| "protocols": ["json"], | ||
| "serviceFullName": "Amazon CodeWhisperer", | ||
| "serviceId": "CodeWhispererRuntime", | ||
| "signatureVersion": "bearer", |
There was a problem hiding this comment.
not sure do we need to include these 3 lines ornot
There was a problem hiding this comment.
think it should be fine, confirmed jb has these. https://github.com/aws/aws-toolkit-jetbrains/blob/main/plugins/core/sdk-codegen/codegen-resources/codewhispererruntime/service-2.json#L4-L15
justinmk3
approved these changes
Nov 8, 2024
|
@justinmk3 fyi i will also request our service team to review the PR then merge |
fangwade007
approved these changes
Nov 8, 2024
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-vscode
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
requested by partner team
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.