Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(amazonq): adjust timeout for supplemental context #5978

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Nov 12, 2024

Problem

The overall supplemental context has a timeout of 50ms, each sub promise has a timeout of 50ms. Problem is these 2 timeout are very tight, leaving no buffer time for node js runtime to do context switch. The poll interval of each sub promise is 10ms, which does not precisely timeout at 50ms.

Solution

Add a 10ms buffer time for supplemental context.
Reduce poll duration


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner November 12, 2024 04:44
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol requested a review from Will-ShaoHua November 12, 2024 04:44
@justinmk3
Copy link
Contributor

The bot comment explains that this pr is marked fix so it should have a changelog. If you're only adjusting something that doesn't have user-facing impact, and thus doesn't need a changelog, use a different type for the PR title. Please do this for future PRs also.

@Will-ShaoHua
Copy link
Contributor

@leigaol changelog or make the subject of this PR config(amazonq)

@leigaol leigaol changed the title fix(amazonq): adjust timeout for supplemental context config(amazonq): adjust timeout for supplemental context Nov 12, 2024
@leigaol
Copy link
Contributor Author

leigaol commented Nov 12, 2024

The bot comment explains that this pr is marked fix so it should have a changelog. If you're only adjusting something that doesn't have user-facing impact, and thus doesn't need a changelog, use a different type for the PR title. Please do this for future PRs also.

Understood. This is updated.

@justinmk3 justinmk3 merged commit 886ab29 into aws:master Nov 12, 2024
31 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants