fix(amazonq): users not able to auto trigger Q inline suggestion on systemVerilog files #5990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
within inline suggestion code path,
isLanguageSupported()
relies onvscode.editor.document.langaugeId
to determine whether the given language is supported Q inline suggestion functionality. However, it's possible that some languages are not recognized by VSCode IDE itself without 3rd party extensions, for example: VSCode doesn't recognize.sv
,svh
,vh
files which is bound to SystemVerilog language if users do not have the 3rd party extension installed and enabled, in this case,vscode.editor.document.languageId
will simply returnplaintext
.This is the root cause why autotrigger doesn't work for systemverilog files, because at the beginning, we don't even register keyStrokeHandler for files with
.sv
,svh
,vh
files.Solution
if language check return false, we should also check file extension
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.