Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(amazonq): inline project context ab #5994

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 13, 2024

Problem

update inline suggestion project context ab test config

CONTROL

  • use bm25 opentabs context

TREATMENT_1

  • use repomap + bm25 open tabs context

TREATMENT_2

  • use bm25 global project context

Solution


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua changed the title test build wip Nov 13, 2024
@Will-ShaoHua Will-ShaoHua changed the title wip wip inline project context ab Nov 13, 2024
@Will-ShaoHua Will-ShaoHua changed the title wip inline project context ab config(amazonq): inline project context ab Nov 13, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 14, 2024 01:08
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners November 14, 2024 01:08
@justinmk3 justinmk3 merged commit 127a7ff into aws:master Nov 14, 2024
22 of 25 checks passed
@Will-ShaoHua Will-ShaoHua deleted the lsp branch November 14, 2024 17:51
@justinmk3
Copy link
Contributor

This correlates with test failures now seen on master (note: there are 2 different test runs; the failure is in the first, near the top of the build logs; search for the string "passing" to find it):

  1) crossFileContextUtil
       fetchSupplementalContextForSrc
         for control group, should return opentabs context where there will be 3 chunks and each chunk should contains 50 lines:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(actual.supplementalContextItems.length === 3)

      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (test/unit/codewhisperer/util/crossFileContextUtil.test.ts:51:20)

Will-ShaoHua added a commit to Will-ShaoHua/aws-toolkit-vscode that referenced this pull request Nov 14, 2024
Will-ShaoHua added a commit that referenced this pull request Nov 14, 2024
## Problem
#5994 is causing CI test failure
misuse of `sinon.alwaysReturned()`

## Solution
should use `sinon.returns()`

---

<!--- REMINDER: Ensure that your PR meets the guidelines in
CONTRIBUTING.md -->

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants