-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(amazonq): inline project context ab #5994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will-ShaoHua
changed the title
wip inline project context ab
config(amazonq): inline project context ab
Nov 13, 2024
leigaol
reviewed
Nov 14, 2024
packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
Outdated
Show resolved
Hide resolved
leigaol
approved these changes
Nov 14, 2024
leigaol
reviewed
Nov 14, 2024
packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
Show resolved
Hide resolved
leigaol
reviewed
Nov 14, 2024
packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
Show resolved
Hide resolved
This correlates with test failures now seen on master (note: there are 2 different test runs; the failure is in the first, near the top of the build logs; search for the string "passing" to find it):
|
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-vscode
that referenced
this pull request
Nov 14, 2024
Will-ShaoHua
added a commit
that referenced
this pull request
Nov 14, 2024
## Problem #5994 is causing CI test failure misuse of `sinon.alwaysReturned()` ## Solution should use `sinon.returns()` --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
update inline suggestion project context ab test config
CONTROL
TREATMENT_1
TREATMENT_2
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.