test(notifications): integ test from hosted endpoints #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/runIntegrationTests |
hayemaxi
reviewed
Nov 18, 2024
packages/core/src/testInteg/notifications/notifications.test.ts
Outdated
Show resolved
Hide resolved
hayemaxi
reviewed
Nov 18, 2024
Comment on lines
+97
to
+101
| const state = globals.globalState.get<NotificationsState>(controller.storageKey) | ||
| if (state) { | ||
| state.newlyReceived.push(existingNotificationID) | ||
| await globals.globalState.update(controller.storageKey, state) | ||
| } |
There was a problem hiding this comment.
This should usually work, since other tests that run before build the state object if it doesnt exist yet.
But in case the test is running standalone, you should have a default state object. Otherwise, this test will fail.
|
Nice. It would be cool to expand this integ test into different auth states as well. Maybe even try to get to a point where we aren't stubbing the rule engine. |
hayemaxi
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integ test for notifications pulling from hosted file endpoints
Test covers:
Also updated ruleEngine evaluation logic to skip extension id check if in test enviorments. Since we use a fake extension id for testing.