Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): file opening behavior on accepted changes #6012

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

kelvin-klchu
Copy link
Contributor

@kelvin-klchu kelvin-klchu commented Nov 14, 2024

Problem

  • when you accept an individual code change, it will bring up the file window
  • when you update the accepted file, both left and right of the window reflects the changes you made immediately
  • it should only show the changes made on the left, while the right stays the same as the original suggested code change

Solution

  • updated the way vscode.diff is called when opening up the file such that it is the actual file on the left, and the suggested code change stays on the right

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kelvin-klchu kelvin-klchu requested review from a team as code owners November 14, 2024 02:08
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws
Copy link
Contributor

I'll wait for approval from your team before merging

@jpinkney-aws jpinkney-aws merged commit 7389d24 into aws:master Nov 19, 2024
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants