Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(amazonq): fix test failure supplementalContext.test.ts #6021

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 14, 2024

Problem

same issue #6019 is trying to fix
misuse of sinon.alwaysReturned()

failure
https://github.com/aws/aws-toolkit-vscode/actions/runs/11844970504/job/33009408730
https://github.com/aws/aws-toolkit-vscode/actions/runs/11844970504/job/33009410300

Solution

sinon.returns()


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner November 14, 2024 21:30
@Will-ShaoHua Will-ShaoHua marked this pull request as draft November 14, 2024 22:04
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 14, 2024 22:06
@justinmk3 justinmk3 merged commit 545dc4f into aws:master Nov 14, 2024
24 of 35 checks passed
@Will-ShaoHua Will-ShaoHua deleted the lsp branch November 14, 2024 22:26
@justinmk3
Copy link
Contributor

failure seen with latest master: a527f96

 1) crossFileContextUtil
       fetchSupplementalContextForSrc
         for t1 group, should return repomap + opentabs context:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(actual.supplementalContextItems.length === 4)

      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (D:\a\aws-toolkit-vscode\aws-toolkit-vscode\packages\amazonq\test\unit\codewhisperer\util\crossFileContextUtil.test.ts:81:20)

@Will-ShaoHua
Copy link
Contributor Author

checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants