Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(amazonq): fix flaky crossfileContextUtil.test #6032

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 15, 2024

Problem

Solution

call assertTabCount() to wait until text editors are opened correctly


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua changed the title fix flaky crossfileContextUtil.test test(amazonq): fix flaky crossfileContextUtil.test Nov 15, 2024
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua Will-ShaoHua changed the title test(amazonq): fix flaky crossfileContextUtil.test test(amazonq): fix flaky crossfileContextUtil.test [WIP] Nov 15, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 15, 2024 18:03
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner November 15, 2024 18:03
@Will-ShaoHua Will-ShaoHua changed the title test(amazonq): fix flaky crossfileContextUtil.test [WIP] test(amazonq): fix flaky crossfileContextUtil.test Nov 15, 2024
@Will-ShaoHua Will-ShaoHua requested review from justinmk3 and removed request for justinmk3 November 15, 2024 18:17
@justinmk3 justinmk3 merged commit 041e30d into aws:master Nov 15, 2024
34 of 35 checks passed
@Will-ShaoHua Will-ShaoHua deleted the lsp branch November 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants