feat(beta): force debug/verbose logging for Beta users #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -120,6 +123,9 @@ export class ToolkitLogger extends BaseLogger implements vscode.Disposable { | |||
| } | |||
|
|
|||
| override sendToLog(level: LogLevel, message: string | Error, ...meta: any[]): number { | |||
| // XXX: force debug/verbose logs for Beta users. | |||
| level = this.isBeta ? 'info' : level | |||
There was a problem hiding this comment.
I'm not familiar with this code so I can't tell if i'm missing something, but isn't this saying if its beta then use info? I thought we wanted verbose/debug if its beta users
There was a problem hiding this comment.
It forces the "sinks" (log providers such as Output channel, file, etc.) to log at "info" level. This forces the vscode Output channel to show logs that it would otherwise hide.
This is a hack because currently the vscode API doesn't give a way to programmatically set the Output channel log-level.
Pushed an improvement/fix: 87eebd4
ivikash
approved these changes
Nov 15, 2024
Problem: Beta and bug-bash users often need logs. Solution: Log debug/verbose messages at "info" log-level. They will appear as "info" logs in the Output channel, even though they were logged at "debug" or "verbose" level.
justinmk3
commented
Nov 15, 2024
| import { isReleaseVersion } from '../shared/vscode/env' | ||
| import { getRelativeDate } from '../shared/datetime' | ||
|
|
||
| const localize = nls.loadMessageBundle() | ||
| const logger = getLogger('dev/beta') | ||
|
|
||
| const downloadIntervalMs = 1000 * 60 * 60 * 24 // A day in milliseconds | ||
| const downloadIntervalMs = 1000 * 60 * 60 * 3 // 3 hours (8 times/day). |
There was a problem hiding this comment.
increase frequency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Beta and bug-bash users often need logs.
Solution
Log debug/verbose messages at "info" log-level. They will appear as "info" logs in the Output channel, even though they were logged at "debug" or "verbose" level.
Related
https://github.com/aws/aws-toolkit-vscode-staging/pull/1961 confirms CI behavior in a beta branch.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.