feat(amazonq): Using AB variation value as customization name when overridden #6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Nov 15, 2024
packages/amazonq/.changes/next-release/Feature-7ffbdb5d-40c5-4c3e-bc20-63d731bc51d2.json
Outdated
Show resolved
Hide resolved
spfink
changed the title
spfink
force-pushed
the
finks/override
branch
2 times, most recently
from
3a74734 to
f419a47
Compare
spfink
changed the title
spfink
changed the title
spfink
force-pushed
the
finks/override
branch
from
f419a47 to
8c84a45
Compare
spfink
force-pushed
the
finks/override
branch
from
8c84a45 to
219390c
Compare
Will-ShaoHua
approved these changes
Nov 20, 2024
jpinkney-aws
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a customization is overridden via AB, the name of the customization is not shown to users
Solution
Uses the variation field from the customizationArnOverride feature as the name for the customization. This allows the UX to show a customization name when the customizationArn is overriden
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.