Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): fixed bug with high CPU use event loop for security scan findings #6039

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mr-lee
Copy link

@mr-lee mr-lee commented Nov 18, 2024

Problem

Opening the security scan issues webview led to an infinite loop on the update call, consuming significant amounts of customer CPU.

Solution

Updated the webview to not auto-update, and made it so that each "view" command opened a new window, even if already present.

This isn't fully ideal, but it at least immediately fixes the CPU consumption issue. Any setup to watch/poll for updates from the server would be either expensive or latent. This will be the most clean, but may lead to a different UX than expected.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mr-lee mr-lee requested a review from a team as a code owner November 18, 2024 06:21
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws
Copy link
Contributor

looks good from my side, still needs an additional review from the security scan team

@ashishrp-aws ashishrp-aws merged commit 10a9458 into aws:master Nov 19, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants