fix(notifications): update types, field names, cross-window syncing #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
hayemaxi
force-pushed
the
notifications4
branch
2 times, most recently
from
679619e to
360c7f6
Compare
nkomonen-amazon
approved these changes
Nov 18, 2024
| @@ -13,7 +13,7 @@ import { AuthState } from './types' | |||
| import { getLogger } from '../shared/logger/logger' | |||
|
|
|||
| /** Time in MS to poll for emergency notifications */ | |||
| const emergencyPollTime = 1000 * 10 * 60 | |||
| const emergencyPollTime = 1000 * 60 * 10 | |||
There was a problem hiding this comment.
I added in some constants for time in datetime.ts, we should look to start using these
- Make types more granular. - Align names - fix onRecieve typo, openTxt -> openTextDocument - Sync from global state on reload to detect activity in other windows. This makes it so that if users dismiss in one window, it will dismiss in all windows. It will also prevent a bug where users may get dismissed notifications again if they have multiple windows.
hayemaxi
force-pushed
the
notifications4
branch
from
360c7f6 to
cf46d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.