fix(amazon q): add pl/1 and bms extensions as a recognized code file type #6067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
scottwritescode
changed the title
scottwritescode
changed the title
scottwritescode
changed the title
scottwritescode
changed the title
|
Thanks for your help here. These filetypes are decided by the Q service team when they feel like the service is ready to handle particular cases. However, I have forwarded this to them. |
justinmk3
reviewed
Nov 28, 2024
packages/amazonq/.changes/next-release/Bug Fix-80f16b7a-440d-4e06-89ad-1454c58ff28f.json
Outdated
Show resolved
Hide resolved
…e06-89ad-1454c58ff28f.json
willyyhuang
approved these changes
Nov 28, 2024
packages/amazonq/.changes/next-release/Bug Fix-80f16b7a-440d-4e06-89ad-1454c58ff28f.json
Outdated
Show resolved
Hide resolved
| @@ -161,6 +161,7 @@ export const codefileExtensions = new Set([ | |||
| '.bash', | |||
| '.bat', | |||
| '.boo', | |||
| '.bms', | |||
There was a problem hiding this comment.
nit: this is not sorting alphabetically. but not a blocker
…e06-89ad-1454c58ff28f.json Co-authored-by: wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The codefileExtensions does not contain an extension type for
.pliwhich is the common extension for PL/1, or for.bmswhich is Basic Mapping Support and common for screen definition files in IBM mainframe. Because of this, the files and code in them are not accessible in the workspace context for Amazon Q using the/devquick action.When using the Q quick action '\dev' for
.plior.bmsfiles, Q responds with the following messageSolution
.plias a known code file extension type.bmsas a known code file extension typeNo tests were updated as there are none exclusively for filetype extensions
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.