Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): enable template parameter prompters for all deploy and sync entry points #6069

Conversation

vicheey
Copy link
Contributor

@vicheey vicheey commented Nov 20, 2024

Problem

When deploying a template with parameters, SAM guided action prompts customers to confirm to either use default value or update to a new value values. Such prompters for template parameters value only exist for Deploy Wizard when invoke from : 1). Template file context menu, 2). App builder node deploy button.

Such prompter is missing in

  • Deploy Wizard entry points:
    1. Command palette entry points
    2. Region node context menu
  • Sync Wizard entry points:
    1. Command palette
    2. Region node context menu
    3. Template file context menu
    4. Samconfig file context menu
    5. App Builder node deploy button

Solution

  • Implement nested wizard for template parameter for both sync and deploy action for all entry points.
  • Refactor DeployWizard class for consistency with SyncWizard class
  • Add unit test for validating correct backward flow and state restoration for both wizard.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@vicheey vicheey force-pushed the add-sam-deploy-parameter-prompter-all-entry-point branch from 68c8299 to 37fae08 Compare November 20, 2024 22:08
@vicheey vicheey closed this Dec 13, 2024
@vicheey
Copy link
Contributor Author

vicheey commented Dec 13, 2024

Close this in favor of #6240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant