Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): Redirect view logs action to open the terminal instead of output channel #6103

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

mbfreder
Copy link
Contributor

Problem

When a build error occurs, the error details are correctly shown under the "Terminal" tab. However, the toast notification says "build failed" with a button to "See logs." Clicking this button incorrectly redirects the user to the "Output" tab, which only shows a generic message (Error: sam build exited with a non-zero exit code: 1 [NonZeroExitCode]), instead of the detailed logs from the "Terminal" tab. This creates confusion and makes troubleshooting more difficult.

Solution

Redirect view logs action to open the terminal instead of output channel


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mbfreder mbfreder requested a review from a team as a code owner November 25, 2024 21:03
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@hayemaxi
Copy link
Contributor

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.

    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Users can notice this change - please add a changelog item.

Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changelog item

@hayemaxi hayemaxi merged commit 9466f98 into aws:master Nov 27, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants