refactor(logs): drop "Amazon Q Logs" channel and just have "Amazon Q" #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Nov 27, 2024
Problem We didn't have much use for the old "Amazon Q" channel in addition to "Amazon Q Logs". All the logs we used were in "Amazon Q Logs". Solution Now, just have the useful "Amazon Q Logs" channel. Signed-off-by: nkomonen-amazon <[email protected]>
Signed-off-by: nkomonen-amazon <[email protected]>
We want to have everything in one place. Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
removeQOutputChannel
branch
from
01d945b to
642c1a5
Compare
justinmk3
reviewed
Nov 27, 2024
| @@ -201,6 +201,9 @@ export async function activate(extensionContext: ExtensionContext) { | |||
| // this is used by LSP to determine index cache path, move to this folder so that when extension updates index is not deleted. | |||
| extensionPath: path.join(fs.getUserHomeDir(), '.aws', 'amazonq', 'cache'), | |||
| }, | |||
| // Log to the Amazon Q Logs so everything is in a single channel | |||
| // TODO: Add prefix to the language server logs so it is easier to search | |||
| outputChannel: globals.logOutputChannel, | |||
|
/retryBuilds |
justinmk3
approved these changes
Dec 2, 2024
nkomonen-amazon
merged commit 6d5e016
into
aws:feature/postreinvent
42 of 45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We didn't have much use for the old "Amazon Q" channel in addition to "Amazon Q Logs". All the logs we used were in "Amazon Q Logs".
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.