Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(jscpd): validate branch name before running CI" #6189

Closed
wants to merge 1 commit into from
Closed

Revert "build(jscpd): validate branch name before running CI" #6189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions .github/workflows/copyPasteDetection.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# # github actions: https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-nodejs
# # setup-node: https://github.com/actions/setup-node

# name: Copy-Paste Detection

# on:
# pull_request:
# branches: [master, feature/*, staging]

# jobs:
# jscpd:
# runs-on: ubuntu-latest
# strategy:
# matrix:
# node-version: [18.x]
# env:
# NODE_OPTIONS: '--max-old-space-size=8192'

# steps:
# - uses: actions/checkout@v4
# with:
# fetch-depth: 0

# - name: Use Node.js ${{ matrix.node-version }}
# uses: actions/setup-node@v4
# with:
# node-version: ${{ matrix.node-version }}

# - name: Fetch fork upstream
# run: |
# git remote add forkUpstream https://github.com/${{ github.event.pull_request.head.repo.full_name }} # URL of the fork
# git fetch forkUpstream # Fetch fork

# - name: Determine base and target branches for comparison.
# run: |
# echo "CURRENT_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV
# echo "TARGET_BRANCH=${{ github.event.pull_request.base.ref }}" >> $GITHUB_ENV
# - run: git diff --name-only origin/$TARGET_BRANCH forkUpstream/$CURRENT_BRANCH > diff_output.txt
# - run: |
# npm install -g jscpd

# - run: jscpd --config "$GITHUB_WORKSPACE/.github/workflows/jscpd.json"

# - if: always()
# uses: actions/upload-artifact@v4
# with:
# name: unfiltered-jscpd-report
# path: ./jscpd-report.json

# - name: Filter jscpd report for changed files
# run: |
# if [ ! -f ./jscpd-report.json ]; then
# echo "jscpd-report.json not found"
# exit 1
# fi
# echo "Filtering jscpd report for changed files..."
# CHANGED_FILES=$(jq -R -s -c 'split("\n")[:-1]' diff_output.txt)
# echo "Changed files: $CHANGED_FILES"
# jq --argjson changed_files "$CHANGED_FILES" '
# .duplicates | map(select(
# (.firstFile?.name as $fname | $changed_files | any(. == $fname)) or
# (.secondFile?.name as $sname | $changed_files | any(. == $sname))
# ))
# ' ./jscpd-report.json > filtered-jscpd-report.json
# cat filtered-jscpd-report.json

# - name: Check for duplicates
# run: |
# if [ $(wc -l < ./filtered-jscpd-report.json) -gt 1 ]; then
# echo "filtered_report_exists=true" >> $GITHUB_ENV
# else
# echo "filtered_report_exists=false" >> $GITHUB_ENV
# fi
# - name: upload filtered report (if applicable)
# if: env.filtered_report_exists == 'true'
# uses: actions/upload-artifact@v4
# with:
# name: filtered-jscpd-report
# path: ./filtered-jscpd-report.json

# - name: Fail and log found duplicates.
# if: env.filtered_report_exists == 'true'
# run: |
# cat ./filtered-jscpd-report.json
# echo "Duplications found, failing the check."
# exit 1
67 changes: 0 additions & 67 deletions .github/workflows/lintbranch.js
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: '20'
- name: Check Branch title
env:
BRANCH_NAME: ${{ github.head_ref }}
run: |
node "$GITHUB_WORKSPACE/.github/workflows/lintbranch.js" run "$BRANCH_NAME"
- name: Check PR title
run: |
node "$GITHUB_WORKSPACE/.github/workflows/lintcommit.js"
Expand All @@ -60,87 +55,6 @@ jobs:
- run: npm run testCompile
- run: npm run lint

jscpd:
needs: lint-commits
if: ${{ github.event_name == 'pull_request'}}
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
env:
NODE_OPTIONS: '--max-old-space-size=8192'

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Fetch fork upstream
env:
REPO_NAME: ${{ github.event.pull_request.head.repo.full_name }}
run: |
git remote add forkUpstream https://github.com/$REPO_NAME # URL of the fork
git fetch forkUpstream # Fetch fork

- name: Compute git diff
env:
CURRENT_BRANCH: ${{ github.head_ref }}
TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
run: git diff --name-only origin/$TARGET_BRANCH forkUpstream/$CURRENT_BRANCH > diff_output.txt

- run: npm install -g jscpd

- run: jscpd --config "$GITHUB_WORKSPACE/.github/workflows/jscpd.json"

- if: always()
uses: actions/upload-artifact@v4
with:
name: unfiltered-jscpd-report
path: ./jscpd-report.json

- name: Filter jscpd report for changed files
run: |
if [ ! -f ./jscpd-report.json ]; then
echo "jscpd-report.json not found"
exit 1
fi
echo "Filtering jscpd report for changed files..."
CHANGED_FILES=$(jq -R -s -c 'split("\n")[:-1]' diff_output.txt)
echo "Changed files: $CHANGED_FILES"
jq --argjson changed_files "$CHANGED_FILES" '
.duplicates | map(select(
(.firstFile?.name as $fname | $changed_files | any(. == $fname)) or
(.secondFile?.name as $sname | $changed_files | any(. == $sname))
))
' ./jscpd-report.json > filtered-jscpd-report.json
cat filtered-jscpd-report.json

- name: Check for duplicates
run: |
if [ $(wc -l < ./filtered-jscpd-report.json) -gt 1 ]; then
echo "filtered_report_exists=true" >> $GITHUB_ENV
else
echo "filtered_report_exists=false" >> $GITHUB_ENV
fi
- name: upload filtered report (if applicable)
if: env.filtered_report_exists == 'true'
uses: actions/upload-artifact@v4
with:
name: filtered-jscpd-report
path: ./filtered-jscpd-report.json

- name: Fail and log found duplicates.
if: env.filtered_report_exists == 'true'
run: |
cat ./filtered-jscpd-report.json
echo "Duplications found, failing the check."
exit 1

macos:
needs: lint-commits
name: test macOS
Expand Down
Loading