Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard PyTorch 1.13 Training, PyTorch 2.1 Training/Inference to Autopatching #3814

Closed
wants to merge 24 commits into from

Conversation

sirutBuasai
Copy link
Contributor

@sirutBuasai sirutBuasai commented Apr 8, 2024

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Tests run

  • 5664a99 - PT 2.1 EC2 DLC
    • Passed sanity test
    • Passed ec2 test
    • Passed eks test
    • Passed ecs test
    • Passed benchmark test

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

Expand
  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

Formatting

DLC image/dockerfile

Builds to Execute

Expand

Click the checkbox to enable a build to execute upon merge.

Note: By default, pipelines are set to "latest". Replace with major.minor framework version if you do not want "latest".

  • build_pytorch_training_latest
  • build_pytorch_inference_latest
  • build_tensorflow_training_latest
  • build_tensorflow_inference_latest
  • [x ] build_pytorch_training_2.1
  • build_pytorch_inference_2.1
  • [x ] build_pytorch_training_1.13

Additional context

PR Checklist

Expand
  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ec2_benchmark_tests = true or sagemaker_benchmark_tests = true

Pytest Marker Checklist

Expand
  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirutBuasai sirutBuasai requested review from a team as code owners April 8, 2024 17:05
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR labels Apr 8, 2024
@sirutBuasai sirutBuasai enabled auto-merge (squash) April 17, 2024 23:52
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added sagemaker_tests test Reflects file change in test folder labels Apr 18, 2024
@sirutBuasai sirutBuasai changed the title Onboard PyTorch 1.13 Training, PyTorch 2.1 Training/Inference to Auto… Onboard PyTorch 1.13 Training, PyTorch 2.1 Training/Inference to Autopatching Apr 19, 2024
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the ec2 Reflects file change in dlc_tests/ec2 folder label Apr 19, 2024
auto-merge was automatically disabled April 19, 2024 19:55

Pull request was closed

@sirutBuasai sirutBuasai deleted the onboard-pt-autopatch branch April 19, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Reflects file change in build folder ec2 Reflects file change in dlc_tests/ec2 folder pytorch Reflects file change in pytorch folder sagemaker_tests Size:S Determines the size of the PR test Reflects file change in test folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant