Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix on telemetry fixture and update skip logging #4405

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Minor fix on telemetry fixture and update skip logging #4405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/dlc_tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ def telemetry():
is_telemetry_test_job = os.getenv("TEST_TYPE") == "telemetry"
if is_mainline_context() and not is_telemetry_test_job:
pytest.skip(
f"Test in not running in telemetry job in the pipeline context, Skipping current test."
f"Test in not running in `telemetry` job in the pipeline context, Skipping current test."
)


Expand All @@ -1055,7 +1055,7 @@ def security_sanity():
is_security_sanity_test_job = os.getenv("TEST_TYPE") == "security_sanity"
if (is_pr_context() or is_mainline_context()) and not is_security_sanity_test_job:
pytest.skip(
f"Test in not running in `security_sanity` test type within the pipeline context, Skipping current test."
f"Test in not running in `security_sanity` test type job, Skipping current test."
)


Expand All @@ -1070,7 +1070,7 @@ def functionality_sanity():
is_functionality_sanity_test_job = os.getenv("TEST_TYPE") == "functionality_sanity"
if (is_pr_context() or is_mainline_context()) and not is_functionality_sanity_test_job:
pytest.skip(
f"Test in not running in `functionality_sanity` test type within the pipeline context, Skipping current test."
f"Test in not running in `functionality_sanity` test type job, Skipping current test."
)


Expand Down
4 changes: 2 additions & 2 deletions test/dlc_tests/ec2/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def test_telemetry_instance_tag_failure_graviton_gpu(


@pytest.mark.flaky(reruns=2)
@pytest.mark.usefixtures("sagemaker")
@pytest.mark.usefixtures("sagemaker", "telemetry")
@pytest.mark.model("N/A")
@pytest.mark.processor("cpu")
@pytest.mark.integration("telemetry")
Expand Down Expand Up @@ -90,7 +90,7 @@ def test_telemetry_instance_tag_failure_neuron(neuron, ec2_client, ec2_instance,

@pytest.mark.flaky(reruns=2)
@pytest.mark.usefixtures("feature_aws_framework_present")
@pytest.mark.usefixtures("sagemaker")
@pytest.mark.usefixtures("sagemaker", "telemetry")
@pytest.mark.model("N/A")
@pytest.mark.processor("gpu")
@pytest.mark.integration("telemetry")
Expand Down
Loading