Don't roll KCP when etcd not ready or no endpoints #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XL
abhinavmpandey08
approved these changes
Aug 17, 2023
g-gaston
force-pushed
the
empty-endpoints-etcd-kcp-backport
branch
from
6aaaf60
to
4eb844c
Compare
|
New changes are detected. LGTM label has been removed. |
g-gaston
force-pushed
the
empty-endpoints-etcd-kcp-backport
branch
from
4eb844c
to
e70c76c
Compare
|
fixed checksums, adding lgtm manually |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Coming from abhay-krishna/cluster-api#26 and abhay-krishna/cluster-api#25
This should be another layer of protection if something happens with the etcd nodes, at leats KCP won't roll new nodes with empty etcd endpoints.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.