adds deferred variable cache to common.mk #2537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We use a decent amount of shell calls in out makefiles. Because we currently defer these, they get resolved a number of times, every time they are used in the context of the makefile. We could change these to immediately resolved variables, however that means we would exec these shell calls at the start of every make invocation, even tho they may not be needed for the specific target being called. This PR introduces a caching mechanism for these deferred variables and a helper to overwrite variables by name to be automatically cached on their first resolution.
Commits:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.