Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip project upgrade for packages on release branches #3506

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jul 22, 2024

Description of changes:
Packages presubmits are made to run only on main in aws/eks-anywhere-prow-jobs#402 as the packages are build/release only off of main in codebuild. This PR skips upgrading the packages projects on branches other than main.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2024
@sp1999
Copy link
Member Author

sp1999 commented Jul 22, 2024

/approve

@sp1999
Copy link
Member Author

sp1999 commented Jul 22, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Jul 22, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999 sp1999 force-pushed the skip-packages-upgrade branch from f0c4b2f to 6f51237 Compare July 22, 2024 18:27
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,sp1999]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 0b73354 into aws:main Jul 22, 2024
1 check passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #3507

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #3508

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants