Update EKS-A version in brew to v0.17.4 (#6827) #20768
eks-distro-botAnnotations
10 errors and 10 warnings
|
lint:
pkg/retrier/retrier_test.go#L19
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L39
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L72
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L95
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L118
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L145
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L175
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L190
var-declaration: should drop = nil from declaration of var retrier; it is the zero value (revive)
|
|
lint:
pkg/types/cluster.go#L5
exported: exported type Cluster should have comment or be unexported (revive)
|
|
lint:
pkg/types/cluster.go#L20
exported: exported type InfrastructureBundle should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L52
unexported-return: exported func New returns unexported type *github.githubProvider, which can be annoying to use (revive)
|
|
lint:
pkg/git/providers/github/github.go#L19
exported: exported const GitProviderName should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L33
exported: exported type Options should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L40
exported: type name will be used as github.GithubClient by other packages, and that stutters; consider calling this Client (revive)
|
|
lint:
pkg/git/providers/github/github.go#L133
exported: exported function GetGithubAccessTokenFromEnv should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L157
exported: exported type GitProviderNotFoundError should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L165
exported: exported function RepoUrl should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L22
var-naming: const githubUrlTemplate should be githubURLTemplate (revive)
|
|
lint:
pkg/git/factory/gitfactory.go#L37
var-naming: var repoUrl should be repoURL (revive)
|
|
lint:
pkg/git/factory/gitfactory.go#L98
var-naming: func parameter repoUrl should be repoURL (revive)
|