-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for provider support of optional configurations #6538
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6538 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 544 544
Lines 41963 41963
=======================================
Hits 29940 29940
Misses 10345 10345
Partials 1678 1678 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: taneyland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all these relative links can be done with [a relative link](other_file.md)
instead.
removing approve bc prow seems to be waiting for this PR and it won't merge until requested changes are resolved /remove-approve |
/approve cancel |
a582400
to
db00c2a
Compare
New changes are detected. LGTM label has been removed. |
Talked to @chrisnegus on what's the recommended way to reference other pages. The reason we try to use relref or ref for internal references to the docs is because Hugo will test the link and fail to build the page if it does not exist. This helps us to avoid broken links. |
/lgtm |
The reason we try to use relref or ref for internal references to the docs is because Hugo will test the link and fail to build the page if it does not exist. This helps us to avoid broken links.
/cherrypick release-0.18 |
@taneyland: new pull request created: #7329 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
Added a provider support matrix for optional configurations + update the supported optional configs on the provider-specific pages
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.