Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for provider support of optional configurations #6538

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

taneyland
Copy link
Member

Issue #, if available:

Description of changes:
Added a provider support matrix for optional configurations + update the supported optional configs on the provider-specific pages

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2023
@taneyland taneyland changed the title Update optional configuration provider support Update docs for provider support of optional configurations Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96f3aae) 71.34% compared to head (db00c2a) 71.34%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6538   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files         544      544           
  Lines       41963    41963           
=======================================
  Hits        29940    29940           
  Misses      10345    10345           
  Partials     1678     1678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vivek-koppuru vivek-koppuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@taneyland
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taneyland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@drewvanstone drewvanstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all these relative links can be done with [a relative link](other_file.md) instead.

@g-gaston
Copy link
Member

removing approve bc prow seems to be waiting for this PR and it won't merge until requested changes are resolved
@taneyland re-approve when you are ready

/remove-approve

@abhay-krishna
Copy link
Member

/approve cancel

@eks-distro-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@taneyland
Copy link
Member Author

I think all these relative links can be done with [a relative link](other_file.md) instead.

Talked to @chrisnegus on what's the recommended way to reference other pages. The reason we try to use relref or ref for internal references to the docs is because Hugo will test the link and fail to build the page if it does not exist. This helps us to avoid broken links.

@chrisnegus
Copy link
Member

/lgtm

@taneyland taneyland dismissed drewvanstone’s stale review November 27, 2023 17:32

The reason we try to use relref or ref for internal references to the docs is because Hugo will test the link and fail to build the page if it does not exist. This helps us to avoid broken links.

@eks-distro-bot eks-distro-bot merged commit 5d20dfd into aws:main Nov 27, 2023
7 checks passed
@taneyland
Copy link
Member Author

/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@taneyland: new pull request created: #7329

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation docathon documentation lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants