-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ETCD encryption in Cloudstack #6557
Add support for ETCD encryption in Cloudstack #6557
Conversation
/hold |
6b12f21
to
df1e0c9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6557 +/- ##
==========================================
+ Coverage 75.64% 75.66% +0.01%
==========================================
Files 474 475 +1
Lines 38303 38359 +56
==========================================
+ Hits 28973 29023 +50
- Misses 7723 7727 +4
- Partials 1607 1609 +2
☔ View full report in Codecov by Sentry. |
2325457
to
2da13d7
Compare
00ac170
to
f45a491
Compare
/unhold |
f45a491
to
95ef6a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/woof
/approve
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pokearu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Add support for ETCD Encryption in Cloudstack using KMS encryption provider.
Testing (if applicable):
Created a cluster, deployed
pod-identity-webhook
and configured IRSA, and deployedaws-encryption-provider
daemonset to start the KMS provider. Then ran upgrade with the encryption config and verified on the etcd node that the secrets were encrypted.Sample CloudStack cluster spec with encryption config:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.