Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinkerbell modular upgrades #6733

Closed
wants to merge 3 commits into from

Conversation

rahulbabu95
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

g-gaston and others added 3 commits September 25, 2023 14:46
… as a pre-flight check for create and upgrade operations.

Signed-off-by: Rahul Ganesh <[email protected]>
@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rahulbabu95. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (81abfa4) 75.66% compared to head (32fe3f3) 75.64%.
Report is 3 commits behind head on main.

❗ Current head 32fe3f3 differs from pull request most recent head a554fe6. Consider uploading reports for the commit a554fe6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6733      +/-   ##
==========================================
- Coverage   75.66%   75.64%   -0.03%     
==========================================
  Files         475      475              
  Lines       38359    38391      +32     
==========================================
+ Hits        29023    29039      +16     
- Misses       7727     7739      +12     
- Partials     1609     1613       +4     
Files Coverage Δ
pkg/api/v1alpha1/cluster_webhook.go 92.81% <ø> (-0.10%) ⬇️
pkg/api/v1alpha1/tinkerbellmachineconfig_types.go 16.90% <ø> (ø)
pkg/providers/tinkerbell/assert.go 70.13% <100.00%> (+0.20%) ⬆️
pkg/providers/tinkerbell/cluster.go 94.00% <100.00%> (+0.12%) ⬆️
pkg/api/v1alpha1/tinkerbellmachineconfig.go 46.15% <0.00%> (-2.50%) ⬇️
pkg/providers/tinkerbell/template.go 67.30% <65.00%> (-0.16%) ⬇️
pkg/providers/tinkerbell/validate.go 79.85% <56.25%> (-2.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulbabu95 rahulbabu95 force-pushed the tinkerbell-modular-upgrades branch from fb79ff0 to 6ceae7f Compare September 26, 2023 23:34
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 26, 2023
@rahulbabu95 rahulbabu95 force-pushed the tinkerbell-modular-upgrades branch from 32fe3f3 to a554fe6 Compare September 26, 2023 23:44
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2023
@rahulbabu95 rahulbabu95 deleted the tinkerbell-modular-upgrades branch September 27, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants