Add wait in between the retries while waiting for failure message to … #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/S
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6752 +/- ##
=======================================
Coverage 75.66% 75.67%
=======================================
Files 475 475
Lines 38404 38411 +7
=======================================
+ Hits 29059 29066 +7
Misses 7733 7733
Partials 1612 1612
☔ View full report in Codecov by Sentry. |
panktishah26
force-pushed
the
add-waittime-failuremessage
branch
from
5ef637b to
899bc75
Compare
g-gaston
reviewed
Sep 29, 2023
…be empty for upgrade management task
panktishah26
force-pushed
the
add-waittime-failuremessage
branch
from
899bc75 to
8a193f9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing (if applicable):
Add wait in between the retries while waiting for failure message to be empty for upgrade management task. Add support for notimeout flag for failure message check.
Currently, the retry doesn't wait enough for machineConfig template to be updated for the management cluster upgrade task so the upgrade process fails. Increased the time out for the retry function by adding wait in between the retry so it doesn't throttle the API server with the requests.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.