Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra logs and increase verbosity of upgrade command for e2e tests #6756

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Oct 2, 2023

Description of changes:
Increase the verbosity of upgrade command for e2e tests and added logs for debugging e2e tests failures.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@panktishah26 panktishah26 changed the title add extra logs and increase verbosity of upgrade command for e2e tests Add extra logs and increase verbosity of upgrade command for e2e tests Oct 2, 2023
@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5428b97) 75.67% compared to head (e871087) 75.67%.
Report is 3 commits behind head on main.

❗ Current head e871087 differs from pull request most recent head ad99b20. Consider uploading reports for the commit ad99b20 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6756   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files         475      475           
  Lines       38411    38414    +3     
=======================================
+ Hits        29066    29069    +3     
  Misses       7733     7733           
  Partials     1612     1612           
Files Coverage Δ
pkg/cluster/wait.go 100.00% <100.00%> (ø)
pkg/clustermanager/applier.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/cluster/wait.go Outdated Show resolved Hide resolved
pkg/cluster/wait.go Outdated Show resolved Hide resolved
pkg/clustermanager/applier.go Outdated Show resolved Hide resolved
@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2023
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panktishah26
Copy link
Member Author

/retest

@eks-distro-bot eks-distro-bot merged commit 81c3676 into aws:main Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants