Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cluster failure support bundle logs #6757

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

panktishah26
Copy link
Member

Description of changes:
For create cluster we need commandContext.BootstrapCluster value for collecting support bundle in case of failure and with the new upgrade management changes we need commandContext.ManagementCluster value for collecting the support bundle. This PR accommodates both the scenarios.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5428b97) 75.67% compared to head (a8c2bf4) 75.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6757   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files         475      475           
  Lines       38411    38411           
=======================================
  Hits        29066    29066           
  Misses       7733     7733           
  Partials     1612     1612           
Files Coverage Δ
pkg/workflows/diagnostics.go 64.51% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panktishah26 panktishah26 merged commit 0f10c3c into aws:main Oct 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants