-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Audit Logs for Tinkerbell #6760
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6760 +/- ##
==========================================
- Coverage 75.67% 71.70% -3.97%
==========================================
Files 475 531 +56
Lines 38411 41126 +2715
==========================================
+ Hits 29066 29488 +422
- Misses 7733 9983 +2250
- Partials 1612 1655 +43
☔ View full report in Codecov by Sentry. |
/retest |
@@ -362,6 +362,11 @@ func buildTemplateMapCP( | |||
etcdTemplateOverride string, | |||
datacenterSpec v1alpha1.TinkerbellDatacenterConfigSpec, | |||
) (map[string]interface{}, error) { | |||
auditPolicy, err := common.GetAuditPolicy(clusterSpec.Cluster.Spec.KubernetesVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then you can move values["auditPolicy"] = auditPolicy
to
values := map[string]interface{}{ |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tatlat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release-0.17 |
@tatlat: #6760 failed to apply on top of branch "release-0.17":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/1883
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.