Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify EKS-A version support for enterprise customer #6778

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (79c297c) 71.70% compared to head (642044f) 71.75%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6778      +/-   ##
==========================================
+ Coverage   71.70%   71.75%   +0.04%     
==========================================
  Files         531      531              
  Lines       41121    41248     +127     
==========================================
+ Hits        29486    29597     +111     
- Misses       9981     9993      +12     
- Partials     1654     1658       +4     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiayiwang7 jiayiwang7 force-pushed the support-version-doc branch from fec383f to d87c938 Compare October 5, 2023 19:16
Copy link
Member

@csplinter csplinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2023
@jiayiwang7
Copy link
Member Author

/approve
/cherry-pick release-0.17

@eks-distro-pr-bot
Copy link
Contributor

@jiayiwang7: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayiwang7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csplinter
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit aad0a9e into aws:main Oct 10, 2023
@eks-distro-pr-bot
Copy link
Contributor

@jiayiwang7: new pull request created: #6794

In response to this:

/approve
/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahreehong pushed a commit to ahreehong/eks-anywhere that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants