Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for EKS-A subscriptions #6796

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

csplinter
Copy link
Member

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 10, 2023
@jonathanmeier5
Copy link
Member

/hold

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f055fc) 75.64% compared to head (3d2e98b) 71.93%.
Report is 161 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6796      +/-   ##
==========================================
- Coverage   75.64%   71.93%   -3.71%     
==========================================
  Files         474      532      +58     
  Lines       38303    41617    +3314     
==========================================
+ Hits        28973    29936     +963     
- Misses       7723    10004    +2281     
- Partials     1607     1677      +70     

see 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editing suggestions.

docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/support-scope.md Outdated Show resolved Hide resolved
@chrisnegus
Copy link
Member

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrisnegus
Copy link
Member

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 7206029 into aws:main Nov 9, 2023
7 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: new pull request created: #7008

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants