Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloudstack Etcd encryption test #6807

Merged

Conversation

abhinavmpandey08
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f79260c) 71.83% compared to head (540bc47) 71.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6807   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         531      531           
  Lines       41350    41353    +3     
=======================================
+ Hits        29703    29706    +3     
  Misses       9981     9981           
  Partials     1666     1666           
Files Coverage Δ
internal/pkg/oidc/keys.go 0.00% <ø> (ø)
internal/pkg/oidc/server.go 67.46% <ø> (ø)
internal/pkg/oidc/token.go 0.00% <ø> (ø)
pkg/api/v1alpha1/cluster_types.go 87.36% <0.00%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavmpandey08
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavmpandey08 abhinavmpandey08 merged commit 5440fe6 into aws:main Oct 12, 2023
@abhinavmpandey08 abhinavmpandey08 deleted the etcd-encryption-cloudstack-e2e branch October 12, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants