Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e for oob configuration #6826

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add e2e for oob configuration #6826

merged 1 commit into from
Oct 17, 2023

Conversation

ahreehong
Copy link
Member

@ahreehong ahreehong commented Oct 16, 2023

Issue #, if available:

Description of changes:
Add E2E tests for out of band management.

Deployed a RPC consumer on the lab CI to handle powering on/off hardware and PXE booting. This test sets the required ENV VARs and runs the eks-a e2e flow using this RPC consumer.

Testing (if applicable):
Ran the e2es locally and verified that it works.

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2023
@ahreehong ahreehong force-pushed the oob-e2e branch 2 times, most recently from 20e48e2 to f61f6fb Compare October 16, 2023 17:59
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c50df49) 71.99% compared to head (1666d09) 72.01%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6826      +/-   ##
==========================================
+ Coverage   71.99%   72.01%   +0.02%     
==========================================
  Files         532      532              
  Lines       41597    41669      +72     
==========================================
+ Hits        29947    30010      +63     
- Misses       9978     9984       +6     
- Partials     1672     1675       +3     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahreehong ahreehong force-pushed the oob-e2e branch 3 times, most recently from 7947067 to 039debc Compare October 17, 2023 19:54
@ahreehong
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahreehong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavmpandey08
Copy link
Member

/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 9168dc4 into aws:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants