-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate worker node kubernetes version with the template name #6828
Validate worker node kubernetes version with the template name #6828
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6828 +/- ##
==========================================
- Coverage 72.01% 72.01% -0.01%
==========================================
Files 532 532
Lines 41669 41640 -29
==========================================
- Hits 30010 29987 -23
+ Misses 9984 9980 -4
+ Partials 1675 1673 -2
☔ View full report in Codecov by Sentry. |
8d1fbc4
to
5e0433a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline comment. I don't think we're doing quite the right checks with these changes and I think the code could benefit from a small refactor to make it clear what our expectations are.
5e0433a
to
c1a3923
Compare
c1a3923
to
16c8bfa
Compare
… spec - modular upgrade scenario
16c8bfa
to
8832ba7
Compare
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
We need to validate worker node specific kubernetes version (if present) in case of modular upgrade with the template name field. The template name field should contain the kubernetes version specified in the workernode configuration if the upgrade type is modular upgrade.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.