Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate worker node kubernetes version with the template name #6828

Merged

Conversation

panktishah26
Copy link
Member

Description of changes:
We need to validate worker node specific kubernetes version (if present) in case of modular upgrade with the template name field. The template name field should contain the kubernetes version specified in the workernode configuration if the upgrade type is modular upgrade.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3d5bbb1) 72.01% compared to head (8832ba7) 72.01%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6828      +/-   ##
==========================================
- Coverage   72.01%   72.01%   -0.01%     
==========================================
  Files         532      532              
  Lines       41669    41640      -29     
==========================================
- Hits        30010    29987      -23     
+ Misses       9984     9980       -4     
+ Partials     1675     1673       -2     
Files Coverage Δ
pkg/providers/cloudstack/validator.go 71.51% <100.00%> (+3.73%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the template-k8s-version-modular-upgrade branch from 8d1fbc4 to 5e0433a Compare October 16, 2023 21:05
@chrisdoherty4 chrisdoherty4 self-requested a review October 17, 2023 19:35
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comment. I don't think we're doing quite the right checks with these changes and I think the code could benefit from a small refactor to make it clear what our expectations are.

pkg/providers/cloudstack/validator.go Show resolved Hide resolved
@panktishah26 panktishah26 force-pushed the template-k8s-version-modular-upgrade branch from 5e0433a to c1a3923 Compare October 18, 2023 00:02
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@panktishah26 panktishah26 force-pushed the template-k8s-version-modular-upgrade branch from c1a3923 to 16c8bfa Compare October 18, 2023 01:08
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
@panktishah26 panktishah26 force-pushed the template-k8s-version-modular-upgrade branch from 16c8bfa to 8832ba7 Compare October 18, 2023 18:55
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 76b841c into aws:main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants