Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcd encryption test #6841

Merged

Conversation

abhinavmpandey08
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2023
Copy link
Member

@pokearu pokearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pokearu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavmpandey08
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b4bb693) 72.02% compared to head (e4640c6) 72.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6841   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files         532      532           
  Lines       41669    41669           
=======================================
  Hits        30013    30013           
  Misses       9982     9982           
  Partials     1674     1674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavmpandey08 abhinavmpandey08 merged commit 77188f8 into aws:main Oct 18, 2023
@abhinavmpandey08 abhinavmpandey08 deleted the fix-etcd-encryption-test branch October 18, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants