-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for recent image-builder enhancements #6854
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6854 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 532 532
Lines 41644 41644
=======================================
+ Hits 29988 29991 +3
+ Misses 9982 9980 -2
+ Partials 1674 1673 -1 ☔ View full report in Codecov by Sentry. |
@@ -997,6 +1042,25 @@ With `image-builder` versions `v0.2.1` and above (released with EKS-A version `v | |||
image-builder build --os <OS> --hypervisor <hypervisor> --release-channel <release channel> --<hypervisor>-config config.json --eksa-release v0.16.5 | |||
``` | |||
|
|||
#### Building images corresponding to dev versions of EKS-A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im fine documenting this because i know we have users doing this, but we should probably add a warning or something that says this is not recommended or its an advanced use case or only do when directed by eks-a engineers, something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty good. lets get something in here about python 3.9
4d5f6b0
to
eb0e480
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.18 |
@abhay-krishna: new pull request created: #6869 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Documenting some recent image-builder enhancements.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.