Automate envtest setup from tests if not configured #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
g-gaston
force-pushed
the
automate-envtest-setup
branch
from
46f6bd7 to
33fb437
Compare
Before this, running a test that required envtest without setting the KUBEBUILDER_ASSETS env var would fail. Now, if the env var is not set, the envtest setup will download the necessary assets and configure the tests to use them. This means that `go test` (on individual tests or whole packages) now works out of the box.
g-gaston
force-pushed
the
automate-envtest-setup
branch
from
33fb437 to
1d7cd27
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6857 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 532 532
Lines 41644 41644
=======================================
Hits 29991 29991
Misses 9980 9980
Partials 1673 1673 ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Before this, running a test that required envtest without setting the KUBEBUILDER_ASSETS env var would fail. Now, if the env var is not set, the envtest setup will download the necessary assets and configure the tests to use them.
This means that
go test(on individual tests or whole packages) now works out of the box.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.