Docs updates for Baremetal configuration #6860
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6860 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 532 532
Lines 41644 41644
=======================================
Hits 29991 29991
Misses 9980 9980
Partials 1673 1673 ☔ View full report in Codecov by Sentry. |
| @@ -91,6 +87,88 @@ spec: | |||
| - ssh-rsa AAAAB3NzaC1yc2... [email protected] | |||
| ``` | |||
|
|
|||
| <pre> | |||
There was a problem hiding this comment.
This section is meant to replace what is still in lines 15-86, right? So I think you need to delete those lines.
| controlPlaneConfiguration: <a href="#controlplaneconfiguration-required"># Specific cluster control plane config (required)</a> | ||
| count: <span style="color:green">2</span> <a href="#controlplaneconfigurationcount-required"># Number of control plane nodes (required)</a> | ||
| endpoint: <a href="#controlplaneconfigurationendpointhost-required"># IP for control plane endpoint (required)</a> | ||
| host: <span>"192.168.0.10"</span> |
There was a problem hiding this comment.
The IP address here (192.168.0.10) is in the range handed out by clusterNetwork.pods.cidrBlocks earlier. The description in this field says not to set the IP address for the endpoint.host to an address that might be handed out by DHCP. You could either just do something generic like "Control Plane Endpoint IP" or use an address outside of that range.
| name: my-cluster-datacenter | ||
| kubernetesVersion: <span>"1.28"</span> <a href="#kubernetesversion-required"># Kubernetes version to use for the cluster (required)</a> | ||
| workerNodeGroupConfigurations: <a href="#workernodegroupconfigurations"># List of node groups you can define for workers (required) </a> | ||
| - count: <span style="color:green">2</span> <a href="#workernodegroupconfigurationscount"># Number of worker nodes </a> |
There was a problem hiding this comment.
The count here is set to "2". The description says: "This number needs to be odd to maintain ETCD quorum."
There was a problem hiding this comment.
I think you are referring the the cp configuration and not worker right? But yea even that is it at 2 right now without external etcd specified here.
| apiVersion: anywhere.eks.amazonaws.com/v1alpha1 | ||
| kind: TinkerbellDatacenterConfig | ||
| metadata: | ||
| name: my-cluster-datacenter |
There was a problem hiding this comment.
Check if you want this to say "my-cluster-datacenter". In previous versions, this was the same name as the cluster name, which was "my-cluster-name".
Issue #, if available:
Description of changes:
Docs updates for Baremetal configuration
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.