Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supfluous context in ForSpec() func #6867

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove supfluous context in ForSpec() func #6867

merged 1 commit into from
Nov 3, 2023

Conversation

chrisdoherty4
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 commented Oct 21, 2023

Removes a superfluous use of context.Context when constructing the global factory data structure.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2023
@chrisdoherty4 chrisdoherty4 requested a review from a team October 21, 2023 01:02
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (14b5003) 72.01% compared to head (73aabfa) 72.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6867   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files         532      532           
  Lines       41644    41644           
=======================================
  Hits        29991    29991           
  Misses       9980     9980           
  Partials     1673     1673           
Files Coverage Δ
cmd/eksctl-anywhere/cmd/createcluster.go 21.91% <0.00%> (ø)
cmd/eksctl-anywhere/cmd/deletecluster.go 9.78% <0.00%> (ø)
cmd/eksctl-anywhere/cmd/generatebundleconfig.go 4.91% <0.00%> (ø)
cmd/eksctl-anywhere/cmd/supportbundle.go 13.11% <0.00%> (ø)
cmd/eksctl-anywhere/cmd/upgradecluster.go 7.18% <0.00%> (ø)
cmd/eksctl-anywhere/cmd/upgradeplancluster.go 7.69% <0.00%> (ø)
cmd/eksctl-anywhere/cmd/validatecreatecluster.go 10.76% <0.00%> (ø)
pkg/dependencies/factory.go 76.29% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26
Copy link
Member

/lgtm

@chrisdoherty4
Copy link
Contributor Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisdoherty4 chrisdoherty4 merged commit 2b4c1a4 into aws:main Nov 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants