Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi templates e2e #6873

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Oct 23, 2023

Issue #, if available:

Description of changes:
This e2e previously didn't set the Kubernetes version of the cluster so it used the default of 1.28, but expected a 1.27 template.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@ahreehong
Copy link
Member

/woof

@eks-distro-bot
Copy link
Collaborator

@ahreehong: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tatlat
Copy link
Member Author

tatlat commented Oct 23, 2023

/approve

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58a6ca5) 72.01% compared to head (8bd0cc9) 72.01%.
Report is 1 commits behind head on main.

❗ Current head 8bd0cc9 differs from pull request most recent head 3def2e4. Consider uploading reports for the commit 3def2e4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6873   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files         532      532           
  Lines       41644    41644           
=======================================
  Hits        29991    29991           
  Misses       9980     9980           
  Partials     1673     1673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat tatlat force-pushed the fix-multi-templates-e2e branch from 8bd0cc9 to 3def2e4 Compare October 23, 2023 20:34
@tatlat
Copy link
Member Author

tatlat commented Oct 23, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 3528d9e into aws:main Oct 23, 2023
3 checks passed
@tatlat
Copy link
Member Author

tatlat commented Oct 23, 2023

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@tatlat: new pull request created: #6875

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants