-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix etcd-encryption for bottlerocket #6874
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6874 +/- ##
==========================================
- Coverage 72.01% 72.01% -0.01%
==========================================
Files 532 532
Lines 41644 41650 +6
==========================================
+ Hits 29991 29994 +3
- Misses 9980 9983 +3
Partials 1673 1673
☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.17 |
@abhinavmpandey08: #6874 failed to apply on top of branch "release-0.17":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.18 |
@abhinavmpandey08: new pull request created: #6877 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Update the path for the encryption config to be compatible with Bottlerocket and add an E2E test for validation]
Also added blocks to restrict etcd encryption to only the supported providers
Testing (if applicable):
Ran the E2E test and verified the changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.