Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kindless upgrade feature flag for all the providers #6879

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

panktishah26
Copy link
Member

Description of changes:
Do not create a kind cluster to upgrade the management cluster of all the providers.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 24, 2023
@panktishah26 panktishah26 force-pushed the remove-kindless-feature-flag branch 3 times, most recently from 9043284 to 5051411 Compare October 24, 2023 19:12
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (58a6ca5) 72.01% compared to head (745eef4) 71.96%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6879      +/-   ##
==========================================
- Coverage   72.01%   71.96%   -0.06%     
==========================================
  Files         532      532              
  Lines       41644    41601      -43     
==========================================
- Hits        29991    29938      -53     
- Misses       9980     9987       +7     
- Partials     1673     1676       +3     
Files Coverage Δ
pkg/api/v1alpha1/cluster_webhook.go 93.66% <100.00%> (+0.85%) ⬆️
pkg/api/v1alpha1/vspheremachineconfig_webhook.go 83.52% <ø> (-4.16%) ⬇️
pkg/clustermanager/eksa_installer.go 81.08% <100.00%> (-4.54%) ⬇️
pkg/controller/clusters/clusterapi.go 84.21% <100.00%> (-7.22%) ⬇️
pkg/features/features.go 19.04% <ø> (+5.25%) ⬆️
cmd/eksctl-anywhere/cmd/upgradecluster.go 7.10% <0.00%> (-0.09%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the remove-kindless-feature-flag branch from fc817e0 to 7905c83 Compare October 24, 2023 22:21
@panktishah26 panktishah26 force-pushed the remove-kindless-feature-flag branch from 7905c83 to 745eef4 Compare October 25, 2023 00:15
@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panktishah26
Copy link
Member Author

/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cxbrowne1207
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit ff55ac1 into aws:main Oct 25, 2023
5 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #6886

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants