Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Status on Docker Reconcile #6882

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Oct 24, 2023

Issue #, if available:
Installing flux on upgrade failed due to a transient error that never cleared for docker clusters.

Description of changes:
Clears the status on docker clusters during reconcile.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ba1416) 72.02% compared to head (1078549) 72.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6882   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files         532      532           
  Lines       41703    41704    +1     
=======================================
+ Hits        30037    30038    +1     
  Misses       9992     9992           
  Partials     1674     1674           
Files Coverage Δ
pkg/providers/docker/reconciler/reconciler.go 95.16% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member Author

tatlat commented Oct 24, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tatlat
Copy link
Member Author

tatlat commented Oct 24, 2023

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@tatlat: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit b70bafb into aws:main Oct 24, 2023
5 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@tatlat: new pull request created: #6883

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants