Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout to wait for cluster generations to be same #6884

Merged

Conversation

panktishah26
Copy link
Member

Description of changes:
For nutanix e2e tests, cluster controller takes some more time to reconcile generation and observered generation value and also takes some more time to reconcile cluster and machineconfig objects. Increased wait time to 10 minutes.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@panktishah26 panktishah26 force-pushed the increase-wait-time-kindless-upgrade branch from 573c4a0 to 2082f0f Compare October 24, 2023 23:57
@panktishah26
Copy link
Member Author

/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ba1416) 72.02% compared to head (2082f0f) 72.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6884   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files         532      532           
  Lines       41703    41704    +1     
=======================================
+ Hits        30037    30038    +1     
  Misses       9992     9992           
  Partials     1674     1674           
Files Coverage Δ
pkg/clustermanager/applier.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member

tatlat commented Oct 25, 2023

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit ff3526b into aws:main Oct 25, 2023
5 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #6885

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants